forked/reqwest-impersonate
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Issue #956: Take the cookie store write lock only when necessary (#960)

Browse Source
This commit is contained in:
Fabian Franz
2020-06-26 21:27:23 +02:00
committed by GitHub
parent f2e8dd2477
commit 7fd6b44cde
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/async_impl/client.rs
View File

@@ -1329,13 +1329,16 @@ impl Future for PendingRequest {
#[cfg(feature = "cookies")] #[cfg(feature = "cookies")]
{ {
if let Some(store_wrapper) = self.client.cookie_store.as_ref() { if let Some(store_wrapper) = self.client.cookie_store.as_ref() {
let mut store = store_wrapper.write().unwrap(); let mut cookies = cookie::extract_response_cookies(&res.headers())
let cookies = cookie::extract_response_cookies(&res.headers())
.filter_map(|res| res.ok()) .filter_map(|res| res.ok())
.map(|cookie| cookie.into_inner().into_owned()); .map(|cookie| cookie.into_inner().into_owned())
.peekable();
if cookies.peek().is_some() {
let mut store = store_wrapper.write().unwrap();
store.0.store_response_cookies(cookies, &self.url); store.0.store_response_cookies(cookies, &self.url);
} }
} }
}
let should_redirect = match res.status() { let should_redirect = match res.status() {
StatusCode::MOVED_PERMANENTLY | StatusCode::FOUND | StatusCode::SEE_OTHER => { StatusCode::MOVED_PERMANENTLY | StatusCode::FOUND | StatusCode::SEE_OTHER => {
self.body = None; self.body = None;