forked/reqwest-impersonate
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove deprecated features (#1124)

Browse Source
This commit is contained in:
Paolo Barbolini
2020-12-30 19:24:57 +01:00
committed by GitHub
parent a19eb34196
commit 3fb2c1c143
2 changed files with 3 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/async_impl/client.rs
View File

@@ -573,12 +573,6 @@ impl ClientBuilder {
self self
} }
#[doc(hidden)]
#[deprecated(note = "the system proxy is used automatically")]
pub fn use_sys_proxy(self) -> ClientBuilder {
self
}
// Timeout options // Timeout options
/// Enables a request timeout. /// Enables a request timeout.
@@ -637,12 +631,6 @@ impl ClientBuilder {
self self
} }
#[doc(hidden)]
#[deprecated(note = "renamed to `pool_max_idle_per_host`")]
pub fn max_idle_per_host(self, max: usize) -> ClientBuilder {
self.pool_max_idle_per_host(max)
}
/// Enable case sensitive headers. /// Enable case sensitive headers.
pub fn http1_title_case_headers(mut self) -> ClientBuilder { pub fn http1_title_case_headers(mut self) -> ClientBuilder {
self.config.http1_title_case_headers = true; self.config.http1_title_case_headers = true;
@@ -676,22 +664,10 @@ impl ClientBuilder {
// TCP options // TCP options
#[doc(hidden)]
#[deprecated(note = "tcp_nodelay is enabled by default, use `tcp_nodelay_` to disable")]
pub fn tcp_nodelay(self) -> ClientBuilder {
self.tcp_nodelay_(true)
}
/// Set whether sockets have `SO_NODELAY` enabled. /// Set whether sockets have `SO_NODELAY` enabled.
/// ///
/// Default is `true`. /// Default is `true`.
// NOTE: Regarding naming (trailing underscore): pub fn tcp_nodelay(mut self, enabled: bool) -> ClientBuilder {
//
// Due to the original `tcp_nodelay()` not taking an argument, changing
// the default means a user has no way of *disabling* this feature.
//
// TODO(v0.11.x): Remove trailing underscore.
pub fn tcp_nodelay_(mut self, enabled: bool) -> ClientBuilder {
self.config.nodelay = enabled; self.config.nodelay = enabled;
self self
} }

28
src/blocking/client.rs
View File

@@ -275,12 +275,6 @@ impl ClientBuilder {
self.with_inner(move |inner| inner.no_proxy()) self.with_inner(move |inner| inner.no_proxy())
} }
#[doc(hidden)]
#[deprecated(note = "the system proxy is used automatically")]
pub fn use_sys_proxy(self) -> ClientBuilder {
self
}
// Timeout options // Timeout options
/// Set a timeout for connect, read and write operations of a `Client`. /// Set a timeout for connect, read and write operations of a `Client`.
@@ -340,12 +334,6 @@ impl ClientBuilder {
self.with_inner(move |inner| inner.pool_max_idle_per_host(max)) self.with_inner(move |inner| inner.pool_max_idle_per_host(max))
} }
#[doc(hidden)]
#[deprecated(note = "use pool_max_idle_per_host instead")]
pub fn max_idle_per_host(self, max: usize) -> ClientBuilder {
self.pool_max_idle_per_host(max)
}
/// Enable case sensitive headers. /// Enable case sensitive headers.
pub fn http1_title_case_headers(self) -> ClientBuilder { pub fn http1_title_case_headers(self) -> ClientBuilder {
self.with_inner(|inner| inner.http1_title_case_headers()) self.with_inner(|inner| inner.http1_title_case_headers())
@@ -372,23 +360,11 @@ impl ClientBuilder {
// TCP options // TCP options
#[doc(hidden)]
#[deprecated(note = "tcp_nodelay is enabled by default, use `tcp_nodelay_` to disable")]
pub fn tcp_nodelay(self) -> ClientBuilder {
self.tcp_nodelay_(true)
}
/// Set whether sockets have `SO_NODELAY` enabled. /// Set whether sockets have `SO_NODELAY` enabled.
/// ///
/// Default is `true`. /// Default is `true`.
// NOTE: Regarding naming (trailing underscore): pub fn tcp_nodelay(self, enabled: bool) -> ClientBuilder {
// self.with_inner(move |inner| inner.tcp_nodelay(enabled))
// Due to the original `tcp_nodelay()` not taking an argument, changing
// the default means a user has no way of *disabling* this feature.
//
// TODO(v0.11.x): Remove trailing underscore.
pub fn tcp_nodelay_(self, enabled: bool) -> ClientBuilder {
self.with_inner(move |inner| inner.tcp_nodelay_(enabled))
} }
/// Bind to a local IP Address. /// Bind to a local IP Address.