Commit Graph

4 Commits

Author SHA1 Message Date
Sean McArthur
cfdabd70ec fix(buffer): zero out new capacity when buffer grows 2015-03-31 16:53:24 -07:00
Sean McArthur
163ffd6f70 perf(buffer): pull in std::io::BufReader improvements
The results of benches/client.rs are below.

Before:

    running 1 test
    test bench_mock_hyper ... bench:    321609 ns/iter (+/- 18127)

After:

    running 1 test
    test bench_mock_hyper ... bench:    239319 ns/iter (+/- 29938)
2015-03-30 18:01:17 -07:00
Sean McArthur
04e3b56515 fix(buffer): get_buf to not return consumed part of buffer
Closes #406
2015-03-29 21:20:09 -07:00
Sean McArthur
cb59f609c6 fix(http): read more before triggering TooLargeError
This includes a custom BufReader, since the one in libstd doesn't allow
reading additional data into the buffer without consuming it. This is
required because some connections may send shorter packets, and so we
need to perform multiple reads. After each read, the contents of the
buffer are passed to httparse to see if have a valid message. If so, the
proper amount of bytes are consumed. The additional bytes are left in
the buffer since they are the beginning of the body.

The buffer in this BufReader also grows in size, compared to the libstd
which is sized once. This is because we start with a smaller buffer,
since the majority of messages will be able to include their head in a
packet or 2. Therefore, it's a wasteful performance hit to allocate the
maximum size for every message. However, some headers can be quite big,
and to allow for many of them to be set, we include a maximum size. Once
we've hit the maximum buffer size, and still haven't determined the end
of the headers, a HttpTooLargeError will be returned.

Closes #389
2015-03-27 10:52:07 -07:00