forked/hyper
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #1159 from dorfsmay/ignore_invalid_cookies

Browse Source 
Ignore invalid cookies
This commit is contained in:
Sean McArthur
2017-05-08 22:46:51 -07:00
committed by GitHub
parent 6655134583 310d98d50b
commit fed04dfb58
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/header/common/cookie.rs
View File

@@ -102,8 +102,6 @@ impl Header for Cookie {
let key_val = (key_val.next(), key_val.next()); let key_val = (key_val.next(), key_val.next());
if let (Some(key), Some(val)) = key_val { if let (Some(key), Some(val)) = key_val {
vec_map.insert(key.trim().to_owned().into(), val.trim().to_owned().into()); vec_map.insert(key.trim().to_owned().into(), val.trim().to_owned().into());
} else {
return Err(::Error::Header);
} }
} }
} }
@@ -213,10 +211,20 @@ mod tests {
cookie.append("foo", "bar"); cookie.append("foo", "bar");
assert_eq!(cookie, parsed); assert_eq!(cookie, parsed);
let parsed = Cookie::parse_header(&b"foo=bar;".to_vec().into()).unwrap();
assert_eq!(cookie, parsed);
let parsed = Cookie::parse_header(&b"foo=bar; baz=quux".to_vec().into()).unwrap(); let parsed = Cookie::parse_header(&b"foo=bar; baz=quux".to_vec().into()).unwrap();
cookie.append("baz", "quux"); cookie.append("baz", "quux");
assert_eq!(cookie, parsed); assert_eq!(cookie, parsed);
let parsed = Cookie::parse_header(&b"foo=bar;; baz=quux".to_vec().into()).unwrap();
assert_eq!(cookie, parsed);
let parsed = Cookie::parse_header(&b"foo=bar; invalid ; bad; ;; baz=quux".to_vec().into())
.unwrap();
assert_eq!(cookie, parsed);
let parsed = Cookie::parse_header(&b" foo = bar;baz= quux ".to_vec().into()).unwrap(); let parsed = Cookie::parse_header(&b" foo = bar;baz= quux ".to_vec().into()).unwrap();
assert_eq!(cookie, parsed); assert_eq!(cookie, parsed);
@@ -241,9 +249,6 @@ mod tests {
.unwrap(); .unwrap();
cookie.append("double", "=2"); cookie.append("double", "=2");
assert_eq!(cookie, parsed); assert_eq!(cookie, parsed);
Cookie::parse_header(&b"foo;bar=baz;quux".to_vec().into()).unwrap_err();
} }
} }