feat(client): Client will retry requests on fresh connections

If a request sees an error on a pooled connection before ever writing
any bytes, it will now retry with a new connection.

This can be configured with `Config::retry_canceled_requests(bool)`.
This commit is contained in:
Sean McArthur
2018-02-15 12:04:58 -08:00
parent 0ea3bcf8d5
commit ee61ea9adf
6 changed files with 234 additions and 124 deletions

View File

@@ -32,7 +32,7 @@ pub struct Server<S: Service> {
}
pub struct Client<B> {
callback: Option<oneshot::Sender<::Result<::Response>>>,
callback: Option<oneshot::Sender<Result<::Response, (::Error, Option<ClientMsg<B>>)>>>,
rx: ClientRx<B>,
}
@@ -398,12 +398,13 @@ where
},
Err(err) => {
if let Some(cb) = self.callback.take() {
let _ = cb.send(Err(err));
let _ = cb.send(Err((err, None)));
Ok(())
} else if let Ok(Async::Ready(Some((_, cb)))) = self.rx.poll() {
} else if let Ok(Async::Ready(Some((req, cb)))) = self.rx.poll() {
trace!("canceling queued request with connection error: {}", err);
// in this case, the message was never even started, so it's safe to tell
// the user that the request was completely canceled
let _ = cb.send(Err(::Error::new_canceled(Some(err))));
let _ = cb.send(Err((::Error::new_canceled(Some(err)), Some(req))));
Ok(())
} else {
Err(err)