refactor(multiple): Clippy run

This commit is contained in:
leonardo.yvens
2016-06-04 11:21:53 -03:00
parent 0c847f7898
commit d4a095d75c
16 changed files with 50 additions and 71 deletions

View File

@@ -95,7 +95,7 @@ impl Display for RangeUnit {
match *self {
RangeUnit::Bytes => f.write_str("bytes"),
RangeUnit::None => f.write_str("none"),
RangeUnit::Unregistered(ref x) => f.write_str(&x),
RangeUnit::Unregistered(ref x) => f.write_str(x),
}
}
}

View File

@@ -182,7 +182,7 @@ impl Display for ContentRangeSpec {
ContentRangeSpec::Unregistered { ref unit, ref resp } => {
try!(f.write_str(&unit));
try!(f.write_str(" "));
f.write_str(&resp)
f.write_str(resp)
}
}
}

View File

@@ -69,14 +69,10 @@ impl Header for Host {
}
};
let port = match idx {
Some(idx) => s[idx + 1..].parse().ok(),
None => None
};
let port = idx.and_then(|idx| s[idx + 1..].parse().ok());
match idx {
Some(idx) => s.truncate(idx),
None => ()
if let Some(idx) = idx {
s.truncate(idx)
}
Ok(Host {

View File

@@ -106,7 +106,7 @@ impl fmt::Display for Preference {
Extension(ref name, ref value, ref params) => {
try!(write!(f, "{}", name));
if value != "" { try!(write!(f, "={}", value)); }
if params.len() > 0 {
if !params.is_empty() {
for &(ref name, ref value) in params {
try!(write!(f, "; {}", name));
if value != "" { try!(write!(f, "={}", value)); }
@@ -138,12 +138,12 @@ impl FromStr for Preference {
Some(param) => {
let rest: Vec<(String, String)> = params.map(|(l, r)| (l.to_owned(), r.to_owned())).collect();
match param {
("respond-async", "") => if rest.len() == 0 { Ok(RespondAsync) } else { Err(None) },
("return", "representation") => if rest.len() == 0 { Ok(ReturnRepresentation) } else { Err(None) },
("return", "minimal") => if rest.len() == 0 { Ok(ReturnMinimal) } else { Err(None) },
("handling", "strict") => if rest.len() == 0 { Ok(HandlingStrict) } else { Err(None) },
("handling", "leniant") => if rest.len() == 0 { Ok(HandlingLeniant) } else { Err(None) },
("wait", secs) => if rest.len() == 0 { secs.parse().map(Wait).map_err(Some) } else { Err(None) },
("respond-async", "") => if rest.is_empty() { Ok(RespondAsync) } else { Err(None) },
("return", "representation") => if rest.is_empty() { Ok(ReturnRepresentation) } else { Err(None) },
("return", "minimal") => if rest.is_empty() { Ok(ReturnMinimal) } else { Err(None) },
("handling", "strict") => if rest.is_empty() { Ok(HandlingStrict) } else { Err(None) },
("handling", "leniant") => if rest.is_empty() { Ok(HandlingLeniant) } else { Err(None) },
("wait", secs) => if rest.is_empty() { secs.parse().map(Wait).map_err(Some) } else { Err(None) },
(left, right) => Ok(Extension(left.to_owned(), right.to_owned(), rest))
}
},

View File

@@ -71,7 +71,7 @@ impl Header for PreferenceApplied {
value.to_owned(),
vec![]
),
preference @ _ => preference.clone()
preference => preference.clone()
}).collect();
fmt_comma_delimited(f, &preferences)
}

View File

@@ -126,7 +126,7 @@ impl FromStr for Range {
type Err = ::Error;
fn from_str(s: &str) -> ::Result<Range> {
let mut iter = s.splitn(2, "=");
let mut iter = s.splitn(2, '=');
match (iter.next(), iter.next()) {
(Some("bytes"), Some(ranges)) => {
@@ -153,7 +153,7 @@ impl FromStr for ByteRangeSpec {
type Err = ::Error;
fn from_str(s: &str) -> ::Result<ByteRangeSpec> {
let mut parts = s.splitn(2, "-");
let mut parts = s.splitn(2, '-');
match (parts.next(), parts.next()) {
(Some(""), Some(end)) => {