diff --git a/src/http/conn.rs b/src/http/conn.rs index fc817f72..e67de63d 100644 --- a/src/http/conn.rs +++ b/src/http/conn.rs @@ -136,7 +136,7 @@ where I: AsyncRead + AsyncWrite, let (reading, ret) = match self.state.reading { Reading::Body(ref mut decoder) => { - let slice = try_nb!(decoder.decode(&mut self.io)); + let slice = try_ready!(decoder.decode(&mut self.io)); if !slice.is_empty() { return Ok(Async::Ready(Some(http::Chunk::from(slice)))); } else if decoder.is_eof() { diff --git a/src/http/h1/decode.rs b/src/http/h1/decode.rs index ad284358..d927613c 100644 --- a/src/http/h1/decode.rs +++ b/src/http/h1/decode.rs @@ -1,6 +1,7 @@ use std::usize; use std::io; +use futures::{Async, Poll}; use bytes::Bytes; use http::io::MemRead; @@ -79,15 +80,15 @@ impl Decoder { } impl Decoder { - pub fn decode(&mut self, body: &mut R) -> io::Result { + pub fn decode(&mut self, body: &mut R) -> Poll { match self.kind { Length(ref mut remaining) => { trace!("Sized read, remaining={:?}", remaining); if *remaining == 0 { - Ok(Bytes::new()) + Ok(Async::Ready(Bytes::new())) } else { let to_read = *remaining as usize; - let buf = try!(body.read_mem(to_read)); + let buf = try_ready!(body.read_mem(to_read)); let num = buf.as_ref().len() as u64; trace!("Length read: {}", num); if num > *remaining { @@ -97,37 +98,33 @@ impl Decoder { } else { *remaining -= num; } - Ok(buf) + Ok(Async::Ready(buf)) } } Chunked(ref mut state, ref mut size) => { loop { let mut buf = None; // advances the chunked state - *state = try!(state.step(body, size, &mut buf)); + *state = try_ready!(state.step(body, size, &mut buf)); if *state == ChunkedState::End { trace!("end of chunked"); - return Ok(Bytes::new()); + return Ok(Async::Ready(Bytes::new())); } if let Some(buf) = buf { - return Ok(buf); + return Ok(Async::Ready(buf)); } } } Eof(ref mut is_eof) => { if *is_eof { - Ok(Bytes::new()) + Ok(Async::Ready(Bytes::new())) } else { // 8192 chosen because its about 2 packets, there probably // won't be that much available, so don't have MemReaders // allocate buffers to big - match body.read_mem(8192) { - Ok(slice) => { - *is_eof = slice.is_empty(); - Ok(slice) - } - other => other, - } + let slice = try_ready!(body.read_mem(8192)); + *is_eof = slice.is_empty(); + Ok(Async::Ready(slice)) } } } @@ -136,7 +133,7 @@ impl Decoder { macro_rules! byte ( ($rdr:ident) => ({ - let buf = try!($rdr.read_mem(1)); + let buf = try_ready!($rdr.read_mem(1)); if !buf.is_empty() { buf[0] } else { @@ -151,22 +148,22 @@ impl ChunkedState { body: &mut R, size: &mut u64, buf: &mut Option) - -> io::Result { + -> Poll { use self::ChunkedState::*; - Ok(match *self { - Size => try!(ChunkedState::read_size(body, size)), - SizeLws => try!(ChunkedState::read_size_lws(body)), - Extension => try!(ChunkedState::read_extension(body)), - SizeLf => try!(ChunkedState::read_size_lf(body, size)), - Body => try!(ChunkedState::read_body(body, size, buf)), - BodyCr => try!(ChunkedState::read_body_cr(body)), - BodyLf => try!(ChunkedState::read_body_lf(body)), - EndCr => try!(ChunkedState::read_end_cr(body)), - EndLf => try!(ChunkedState::read_end_lf(body)), - End => ChunkedState::End, - }) + match *self { + Size => ChunkedState::read_size(body, size), + SizeLws => ChunkedState::read_size_lws(body), + Extension => ChunkedState::read_extension(body), + SizeLf => ChunkedState::read_size_lf(body, size), + Body => ChunkedState::read_body(body, size, buf), + BodyCr => ChunkedState::read_body_cr(body), + BodyLf => ChunkedState::read_body_lf(body), + EndCr => ChunkedState::read_end_cr(body), + EndLf => ChunkedState::read_end_lf(body), + End => Ok(Async::Ready(ChunkedState::End)), + } } - fn read_size(rdr: &mut R, size: &mut u64) -> io::Result { + fn read_size(rdr: &mut R, size: &mut u64) -> Poll { trace!("Read chunk hex size"); let radix = 16; match byte!(rdr) { @@ -182,41 +179,41 @@ impl ChunkedState { *size *= radix; *size += (b + 10 - b'A') as u64; } - b'\t' | b' ' => return Ok(ChunkedState::SizeLws), - b';' => return Ok(ChunkedState::Extension), - b'\r' => return Ok(ChunkedState::SizeLf), + b'\t' | b' ' => return Ok(Async::Ready(ChunkedState::SizeLws)), + b';' => return Ok(Async::Ready(ChunkedState::Extension)), + b'\r' => return Ok(Async::Ready(ChunkedState::SizeLf)), _ => { return Err(io::Error::new(io::ErrorKind::InvalidInput, "Invalid chunk size line: Invalid Size")); } } - Ok(ChunkedState::Size) + Ok(Async::Ready(ChunkedState::Size)) } - fn read_size_lws(rdr: &mut R) -> io::Result { + fn read_size_lws(rdr: &mut R) -> Poll { trace!("read_size_lws"); match byte!(rdr) { // LWS can follow the chunk size, but no more digits can come - b'\t' | b' ' => Ok(ChunkedState::SizeLws), - b';' => Ok(ChunkedState::Extension), - b'\r' => Ok(ChunkedState::SizeLf), + b'\t' | b' ' => Ok(Async::Ready(ChunkedState::SizeLws)), + b';' => Ok(Async::Ready(ChunkedState::Extension)), + b'\r' => Ok(Async::Ready(ChunkedState::SizeLf)), _ => { Err(io::Error::new(io::ErrorKind::InvalidInput, "Invalid chunk size linear white space")) } } } - fn read_extension(rdr: &mut R) -> io::Result { + fn read_extension(rdr: &mut R) -> Poll { trace!("read_extension"); match byte!(rdr) { - b'\r' => Ok(ChunkedState::SizeLf), - _ => Ok(ChunkedState::Extension), // no supported extensions + b'\r' => Ok(Async::Ready(ChunkedState::SizeLf)), + _ => Ok(Async::Ready(ChunkedState::Extension)), // no supported extensions } } - fn read_size_lf(rdr: &mut R, size: &mut u64) -> io::Result { + fn read_size_lf(rdr: &mut R, size: &mut u64) -> Poll { trace!("Chunk size is {:?}", size); match byte!(rdr) { - b'\n' if *size > 0 => Ok(ChunkedState::Body), - b'\n' if *size == 0 => Ok(ChunkedState::EndCr), + b'\n' if *size > 0 => Ok(Async::Ready(ChunkedState::Body)), + b'\n' if *size == 0 => Ok(Async::Ready(ChunkedState::EndCr)), _ => Err(io::Error::new(io::ErrorKind::InvalidInput, "Invalid chunk size LF")), } } @@ -224,7 +221,7 @@ impl ChunkedState { fn read_body(rdr: &mut R, rem: &mut u64, buf: &mut Option) - -> io::Result { + -> Poll { trace!("Chunked read, remaining={:?}", rem); // cap remaining bytes at the max capacity of usize @@ -234,7 +231,7 @@ impl ChunkedState { }; let to_read = rem_cap; - let slice = try!(rdr.read_mem(to_read)); + let slice = try_ready!(rdr.read_mem(to_read)); let count = slice.len(); if count == 0 { @@ -245,33 +242,33 @@ impl ChunkedState { *rem -= count as u64; if *rem > 0 { - Ok(ChunkedState::Body) + Ok(Async::Ready(ChunkedState::Body)) } else { - Ok(ChunkedState::BodyCr) + Ok(Async::Ready(ChunkedState::BodyCr)) } } - fn read_body_cr(rdr: &mut R) -> io::Result { + fn read_body_cr(rdr: &mut R) -> Poll { match byte!(rdr) { - b'\r' => Ok(ChunkedState::BodyLf), + b'\r' => Ok(Async::Ready(ChunkedState::BodyLf)), _ => Err(io::Error::new(io::ErrorKind::InvalidInput, "Invalid chunk body CR")), } } - fn read_body_lf(rdr: &mut R) -> io::Result { + fn read_body_lf(rdr: &mut R) -> Poll { match byte!(rdr) { - b'\n' => Ok(ChunkedState::Size), + b'\n' => Ok(Async::Ready(ChunkedState::Size)), _ => Err(io::Error::new(io::ErrorKind::InvalidInput, "Invalid chunk body LF")), } } - fn read_end_cr(rdr: &mut R) -> io::Result { + fn read_end_cr(rdr: &mut R) -> Poll { match byte!(rdr) { - b'\r' => Ok(ChunkedState::EndLf), + b'\r' => Ok(Async::Ready(ChunkedState::EndLf)), _ => Err(io::Error::new(io::ErrorKind::InvalidInput, "Invalid chunk end CR")), } } - fn read_end_lf(rdr: &mut R) -> io::Result { + fn read_end_lf(rdr: &mut R) -> Poll { match byte!(rdr) { - b'\n' => Ok(ChunkedState::End), + b'\n' => Ok(Async::Ready(ChunkedState::End)), _ => Err(io::Error::new(io::ErrorKind::InvalidInput, "Invalid chunk end LF")), } } @@ -285,19 +282,40 @@ mod tests { use super::Decoder; use super::ChunkedState; use http::io::MemRead; + use futures::{Async, Poll}; use bytes::{BytesMut, Bytes}; use mock::AsyncIo; impl<'a> MemRead for &'a [u8] { - fn read_mem(&mut self, len: usize) -> io::Result { + fn read_mem(&mut self, len: usize) -> Poll { let n = ::std::cmp::min(len, self.len()); if n > 0 { let (a, b) = self.split_at(n); let mut buf = BytesMut::from(a); *self = b; - Ok(buf.split_to(n).freeze()) + Ok(Async::Ready(buf.split_to(n).freeze())) } else { - Ok(Bytes::new()) + Ok(Async::Ready(Bytes::new())) + } + } + } + + trait HelpUnwrap { + fn unwrap(self) -> T; + } + impl HelpUnwrap for Async { + fn unwrap(self) -> Bytes { + match self { + Async::Ready(bytes) => bytes, + Async::NotReady => panic!(), + } + } + } + impl HelpUnwrap for Async { + fn unwrap(self) -> ChunkedState { + match self { + Async::Ready(state) => state, + Async::NotReady => panic!(), } } } @@ -313,7 +331,7 @@ mod tests { loop { let result = state.step(rdr, &mut size, &mut None); let desc = format!("read_size failed for {:?}", s); - state = result.expect(desc.as_str()); + state = result.expect(desc.as_str()).unwrap(); if state == ChunkedState::Body || state == ChunkedState::EndCr { break; } @@ -328,7 +346,7 @@ mod tests { loop { let result = state.step(rdr, &mut size, &mut None); state = match result { - Ok(s) => s, + Ok(s) => s.unwrap(), Err(e) => { assert!(expected_err == e.kind(), "Reading {:?}, expected {:?}, but got {:?}", s, expected_err, e.kind()); @@ -376,7 +394,7 @@ mod tests { fn test_read_sized_early_eof() { let mut bytes = &b"foo bar"[..]; let mut decoder = Decoder::length(10); - assert_eq!(decoder.decode(&mut bytes).unwrap().len(), 7); + assert_eq!(decoder.decode(&mut bytes).unwrap().unwrap().len(), 7); let e = decoder.decode(&mut bytes).unwrap_err(); assert_eq!(e.kind(), io::ErrorKind::Other); assert_eq!(e.description(), "early eof"); @@ -389,7 +407,7 @@ mod tests { foo bar\ "[..]; let mut decoder = Decoder::chunked(); - assert_eq!(decoder.decode(&mut bytes).unwrap().len(), 7); + assert_eq!(decoder.decode(&mut bytes).unwrap().unwrap().len(), 7); let e = decoder.decode(&mut bytes).unwrap_err(); assert_eq!(e.kind(), io::ErrorKind::UnexpectedEof); assert_eq!(e.description(), "early eof"); @@ -398,7 +416,7 @@ mod tests { #[test] fn test_read_chunked_single_read() { let mut mock_buf = &b"10\r\n1234567890abcdef\r\n0\r\n"[..]; - let buf = Decoder::chunked().decode(&mut mock_buf).expect("decode"); + let buf = Decoder::chunked().decode(&mut mock_buf).expect("decode").unwrap(); assert_eq!(16, buf.len()); let result = String::from_utf8(buf.as_ref().to_vec()).expect("decode String"); assert_eq!("1234567890abcdef", &result); @@ -410,17 +428,17 @@ mod tests { let mut decoder = Decoder::chunked(); // normal read - let buf = decoder.decode(&mut mock_buf).expect("decode"); + let buf = decoder.decode(&mut mock_buf).expect("decode").unwrap(); assert_eq!(16, buf.len()); let result = String::from_utf8(buf.as_ref().to_vec()).expect("decode String"); assert_eq!("1234567890abcdef", &result); // eof read - let buf = decoder.decode(&mut mock_buf).expect("decode"); + let buf = decoder.decode(&mut mock_buf).expect("decode").unwrap(); assert_eq!(0, buf.len()); // ensure read after eof also returns eof - let buf = decoder.decode(&mut mock_buf).expect("decode"); + let buf = decoder.decode(&mut mock_buf).expect("decode").unwrap(); assert_eq!(0, buf.len()); } @@ -434,18 +452,15 @@ mod tests { let mut ins = AsyncIo::new(content, block_at); let mut outs = Vec::new(); loop { - match decoder.decode(&mut ins) { - Ok(buf) => { + match decoder.decode(&mut ins).expect("unexpected decode error: {}") { + Async::Ready(buf) => { if buf.is_empty() { break; // eof } outs.write(buf.as_ref()).expect("write buffer"); - } - Err(e) => match e.kind() { - io::ErrorKind::WouldBlock => { - ins.block_in(content_len); // we only block once - }, - _ => panic!("unexpected decode error: {}", e), + }, + Async::NotReady => { + ins.block_in(content_len); // we only block once } }; } diff --git a/src/http/io.rs b/src/http/io.rs index ac6e42b0..4adf26d6 100644 --- a/src/http/io.rs +++ b/src/http/io.rs @@ -3,6 +3,7 @@ use std::fmt; use std::io::{self, Write}; use std::ptr; +use futures::{Async, Poll}; use tokio_io::{AsyncRead, AsyncWrite}; use http::{Http1Transaction, MessageHead, DebugTruncate}; @@ -147,19 +148,19 @@ impl Write for Buffered { } pub trait MemRead { - fn read_mem(&mut self, len: usize) -> io::Result; + fn read_mem(&mut self, len: usize) -> Poll; } impl MemRead for Buffered { - fn read_mem(&mut self, len: usize) -> io::Result { + fn read_mem(&mut self, len: usize) -> Poll { trace!("Buffered.read_mem read_buf={}, wanted={}", self.read_buf.len(), len); if !self.read_buf.is_empty() { let n = ::std::cmp::min(len, self.read_buf.len()); trace!("Buffered.read_mem read_buf is not empty, slicing {}", n); - Ok(self.read_buf.split_to(n).freeze()) + Ok(Async::Ready(self.read_buf.split_to(n).freeze())) } else { - let n = try!(self.read_from_io()); - Ok(self.read_buf.split_to(::std::cmp::min(len, n)).freeze()) + let n = try_nb!(self.read_from_io()); + Ok(Async::Ready(self.read_buf.split_to(::std::cmp::min(len, n)).freeze())) } } } @@ -327,10 +328,10 @@ use std::io::Read; #[cfg(test)] impl MemRead for ::mock::AsyncIo { - fn read_mem(&mut self, len: usize) -> io::Result { + fn read_mem(&mut self, len: usize) -> Poll { let mut v = vec![0; len]; - let n = try!(self.read(v.as_mut_slice())); - Ok(BytesMut::from(&v[..n]).freeze()) + let n = try_nb!(self.read(v.as_mut_slice())); + Ok(Async::Ready(BytesMut::from(&v[..n]).freeze())) } }