forked/hyper
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(http2): preserve proxy-authenticate and proxy-authorization headers (#2597)

Browse Source 
That Proxy-Authenticate and Proxy-Authorization are forbidden over h2
is not actually specified anywhere, plus h2 also supports CONNECT
requests, which are specifically made to do requests over a proxy,
and those proxies may require authentication, sometimes through
Proxy-Authorization.

Note that there is an openwebdocs project that just started to clear
up any MDN-induced confusion in implementations:

	https://github.com/openwebdocs/project/issues/43
This commit is contained in:
Anthony Ramine
2021-07-17 00:48:45 +02:00
committed by GitHub
parent 25d18c0b74
commit 5243570137
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/proto/h2/mod.rs
View File

@@ -1,9 +1,6 @@
use bytes::{Buf, Bytes}; use bytes::{Buf, Bytes};
use h2::{RecvStream, SendStream}; use h2::{RecvStream, SendStream};
use http::header::{ use http::header::{HeaderName, CONNECTION, TE, TRAILER, TRANSFER_ENCODING, UPGRADE};
HeaderName, CONNECTION, PROXY_AUTHENTICATE, PROXY_AUTHORIZATION, TE, TRAILER,
TRANSFER_ENCODING, UPGRADE,
};
use http::HeaderMap; use http::HeaderMap;
use pin_project_lite::pin_project; use pin_project_lite::pin_project;
use std::error::Error as StdError; use std::error::Error as StdError;
@@ -40,8 +37,6 @@ fn strip_connection_headers(headers: &mut HeaderMap, is_request: bool) {
let connection_headers = [ let connection_headers = [
HeaderName::from_lowercase(b"keep-alive").unwrap(), HeaderName::from_lowercase(b"keep-alive").unwrap(),
HeaderName::from_lowercase(b"proxy-connection").unwrap(), HeaderName::from_lowercase(b"proxy-connection").unwrap(),
PROXY_AUTHENTICATE,
PROXY_AUTHORIZATION,
TRAILER, TRAILER,
TRANSFER_ENCODING, TRANSFER_ENCODING,
UPGRADE, UPGRADE,