feat(header): introduce header::Raw (#869)
The Raw type repesents the raw bytes of a header-value. Having a special type allows a couple of benefits: - The exact representation has become private, allowing "uglier" internals. Specifically, since the common case is for a header to only have 1 line of bytes, an enum is used to skip allocating a Vec for only 1 line. Additionally, a Cow<'static, [u8]> is used, so static bytes don't require a copy. Finally, since we can use static bytes, when parsing, we can compare the incoming bytes against a couple of the most common header-values, and possibly remove another copy. - As its own type, the `Headers.set_raw` method can be generic over `Into<Raw>`, which allows for more ergnomic method calls. BREAKING CHANGE: `Header::parse_header` now receives `&Raw`, instead of a `&[Vec<u8>]`. `Raw` provides several methods to ease using it, but may require some changes to existing code.
This commit is contained in:
@@ -1,4 +1,4 @@
|
||||
use header::{Header};
|
||||
use header::{Header, Raw};
|
||||
use std::fmt;
|
||||
use std::str::FromStr;
|
||||
use header::parsing::from_one_raw_str;
|
||||
@@ -49,7 +49,7 @@ impl Header for Host {
|
||||
NAME
|
||||
}
|
||||
|
||||
fn parse_header(raw: &[Vec<u8>]) -> ::Result<Host> {
|
||||
fn parse_header(raw: &Raw) -> ::Result<Host> {
|
||||
from_one_raw_str(raw)
|
||||
}
|
||||
|
||||
@@ -98,14 +98,14 @@ mod tests {
|
||||
|
||||
#[test]
|
||||
fn test_host() {
|
||||
let host = Header::parse_header([b"foo.com".to_vec()].as_ref());
|
||||
let host = Header::parse_header(&vec![b"foo.com".to_vec()].into());
|
||||
assert_eq!(host.ok(), Some(Host {
|
||||
hostname: "foo.com".to_owned(),
|
||||
port: None
|
||||
}));
|
||||
|
||||
|
||||
let host = Header::parse_header([b"foo.com:8080".to_vec()].as_ref());
|
||||
let host = Header::parse_header(&vec![b"foo.com:8080".to_vec()].into());
|
||||
assert_eq!(host.ok(), Some(Host {
|
||||
hostname: "foo.com".to_owned(),
|
||||
port: Some(8080)
|
||||
|
||||
Reference in New Issue
Block a user