forked/hyper
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(headers): errors for parse_header

Browse Source 
Header::parse_header() returns now a hyper Result instead of an option
this will enable more precise Error messages in the future, currently
most failures are reported as ::Error::Header.

BREAKING CHANGE: parse_header returns Result instead of Option, related
code did also change
This commit is contained in:
Pyfisch
2015-06-06 22:04:01 +02:00
parent 763746153e
commit 195a89fa91
19 changed files with 140 additions and 132 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/header/common/pragma.rs
View File

@@ -29,12 +29,12 @@ impl Header for Pragma {
"Pragma"
}
fn parse_header(raw: &[Vec<u8>]) -> Option<Pragma> {
fn parse_header(raw: &[Vec<u8>]) -> ::Result<Pragma> {
parsing::from_one_raw_str(raw).and_then(|s: String| {
let slice = &s.to_ascii_lowercase()[..];
match slice {
"no-cache" => Some(Pragma::NoCache),
_ => Some(Pragma::Ext(s)),
"no-cache" => Ok(Pragma::NoCache),
_ => Ok(Pragma::Ext(s)),
}
})
}
@@ -57,6 +57,6 @@ fn test_parse_header() {
let c: Pragma = Header::parse_header([b"FoObar".to_vec()].as_ref()).unwrap();
let d = Pragma::Ext("FoObar".to_owned());
assert_eq!(c, d);
let e: Option<Pragma> = Header::parse_header([b"".to_vec()].as_ref());
assert_eq!(e, None);
let e: ::Result<Pragma> = Header::parse_header([b"".to_vec()].as_ref());
assert_eq!(e.ok(), None);
}