perf(h1): remove unused error branches from writing body

src/proto/h1/conn.rs

@@ -3,7 +3,7 @@ use std::io::{self};
 use std::marker::PhantomData;
 
 use bytes::{Buf, Bytes};
-use futures::{Async, AsyncSink, Poll, StartSend};
+use futures::{Async, Poll};
 use http::{Method, Version};
 use tokio_io::{AsyncRead, AsyncWrite};
 
@@ -451,25 +451,14 @@ where I: AsyncRead + AsyncWrite,
         }
     }
 
-    pub fn write_body(&mut self, chunk: Option<B>) -> StartSend<Option<B>, io::Error> {
+    pub fn write_body(&mut self, chunk: Option<B>) {
-        debug_assert!(self.can_write_body());
+        debug_assert!(self.can_write_body() && self.can_buffer_body());
-
-        if !self.can_buffer_body() {
-            if let Async::NotReady = self.flush()? {
-                // if chunk is Some(&[]), aka empty, whatever, just skip it
-                if chunk.as_ref().map(|c| c.remaining() == 0).unwrap_or(false) {
-                    return Ok(AsyncSink::Ready);
-                } else {
-                    return Ok(AsyncSink::NotReady(chunk));
-                }
-            }
-        }
 
         let state = match self.state.writing {
             Writing::Body(ref mut encoder) => {
                 if let Some(chunk) = chunk {
                     if chunk.remaining() == 0 {
-                        return Ok(AsyncSink::Ready);
+                        return;
                     }
 
                     let encoded = encoder.encode(chunk);
@@ -482,7 +471,7 @@ where I: AsyncRead + AsyncWrite,
                             Writing::KeepAlive
                         }
                     } else {
-                        return Ok(AsyncSink::Ready);
+                        return;
                     }
                 } else {
                     // end of stream, that means we should try to eof
@@ -505,7 +494,6 @@ where I: AsyncRead + AsyncWrite,
         };
 
         self.state.writing = state;
-        Ok(AsyncSink::Ready)
     }
 
     // When we get a parse error, depending on what side we are, we might be able

src/proto/h1/dispatch.rs

@@ -242,7 +242,7 @@ where
                     },
                     Async::Ready(None) => {
                         if self.conn.can_write_body() {
-                            self.conn.write_body(None).map_err(::Error::new_body_write)?;
+                            self.conn.write_body(None);
                         }
                         continue;
                     },
@@ -253,7 +253,7 @@ where
                 };
 
                 if self.conn.can_write_body() {
-                    self.conn.write_body(Some(chunk)).map_err(::Error::new_body_write)?;
+                    self.conn.write_body(Some(chunk));
                 // This allows when chunk is `None`, or `Some([])`.
                 } else if chunk.remaining() == 0 {
                     // ok