forked/h2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix trailers without EOS flag to be a stream instead of connection error (#377)

Browse Source 
[Trailers without EOS](https://httpwg.org/specs/rfc7540.html#HttpSequence):

> An endpoint that receives a HEADERS frame without the END_STREAM flag set after receiving a final (non-informational) status code MUST treat the corresponding request or response as malformed (Section 8.1.2.6).

[Malformed messages](https://httpwg.org/specs/rfc7540.html#malformed):

> Malformed requests or responses that are detected MUST be treated as a stream error (Section 5.4.2) of type PROTOCOL_ERROR.
This commit is contained in:
Sean McArthur
2019-06-26 13:38:06 -07:00
committed by GitHub
parent c616ac4611
commit f8f05d04e7
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/proto/streams/streams.rs
View File

@@ -204,9 +204,13 @@ where
} }
} else { } else {
if !frame.is_end_stream() { if !frame.is_end_stream() {
// TODO: Is this the right error // Receiving trailers that don't set EOS is a "malformed"
proto_err!(conn: "recv_headers: trailers frame was not EOS; stream={:?}", stream.id); // message. Malformed messages are a stream error.
return Err(RecvError::Connection(Reason::PROTOCOL_ERROR)); proto_err!(stream: "recv_headers: trailers frame was not EOS; stream={:?}", stream.id);
return Err(RecvError::Stream {
id: stream.id,
reason: Reason::PROTOCOL_ERROR,
});
} }
actions.recv.recv_trailers(frame, stream) actions.recv.recv_trailers(frame, stream)