forked/h2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix receiving a GOAWAY frame from updating the max recv ID

Browse Source 
Receiving a GOAWAY should update the max *send* ID, it shouldn't affect
the max recv.
This commit is contained in:
Sean McArthur
2020-03-24 17:36:13 -07:00
parent 5041a4d428
commit d6dc63276f
4 changed files with 116 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/proto/streams/streams.rs
View File

@@ -392,25 +392,11 @@ where
let send_buffer = &mut *send_buffer;
let last_stream_id = frame.last_stream_id();
actions.send.recv_go_away(last_stream_id)?;
let err = frame.reason().into();
if last_stream_id > actions.recv.max_stream_id() {
// The remote endpoint sent a `GOAWAY` frame indicating a stream
// that we never sent, or that we have already terminated on account
// of previous `GOAWAY` frame. In either case, that is illegal.
// (When sending multiple `GOAWAY`s, "Endpoints MUST NOT increase
// the value they send in the last stream identifier, since the
// peers might already have retried unprocessed requests on another
// connection.")
proto_err!(conn:
"recv_go_away: last_stream_id ({:?}) > max_stream_id ({:?})",
last_stream_id, actions.recv.max_stream_id(),
);
return Err(RecvError::Connection(Reason::PROTOCOL_ERROR));
}
actions.recv.go_away(last_stream_id);
me.store
.for_each(|stream| {
if stream.id > last_stream_id {