From 9737d0c6a0e7fc42b96cc388aa5bacae7222a40f Mon Sep 17 00:00:00 2001 From: Sean McArthur Date: Thu, 5 Oct 2017 17:09:51 -0700 Subject: [PATCH] convert several unimplemented into proper asserts --- src/proto/streams/recv.rs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/proto/streams/recv.rs b/src/proto/streams/recv.rs index 37cd156..7d363f6 100644 --- a/src/proto/streams/recv.rs +++ b/src/proto/streams/recv.rs @@ -263,9 +263,9 @@ where ) -> Result<(), RecvError> { let sz = frame.payload().len(); - if sz > MAX_WINDOW_SIZE as usize { - unimplemented!(); - } + // This should have been enforced at the codec::FramedRead layer, so + // this is just a sanity check. + assert!(sz <= MAX_WINDOW_SIZE as usize); let sz = sz as WindowSize; @@ -611,7 +611,7 @@ where // TODO: This is a user error. `poll_trailers` was called before // the entire set of data frames have been consumed. What should // we do? - unimplemented!(); + panic!("poll_trailers called before data has been consumed"); }, None => self.schedule_recv(stream), } @@ -654,7 +654,7 @@ where // frame or the user violated the contract. match stream.pending_recv.pop_front(&mut self.buffer) { Some(Event::Headers(response)) => Ok(response.into()), - Some(_) => unimplemented!(), + Some(_) => panic!("poll_response called after response returned"), None => { stream.state.ensure_recv_open()?;