From 26e7a2d4165d500ee8426a10d2919e40663b4160 Mon Sep 17 00:00:00 2001
From: Sean McArthur <sean@seanmonstar.com>
Date: Tue, 2 Jan 2018 12:49:41 -0800
Subject: [PATCH] remove erroneous assert when stream has buffered send data
 (#209)

---
 src/proto/streams/prioritize.rs |  2 --
 tests/flow_control.rs           | 46 +++++++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+), 2 deletions(-)

diff --git a/src/proto/streams/prioritize.rs b/src/proto/streams/prioritize.rs
index 994da93..8ba74bd 100644
--- a/src/proto/streams/prioritize.rs
+++ b/src/proto/streams/prioritize.rs
@@ -370,8 +370,6 @@ impl Prioritize {
 
         // If data is buffered, then schedule the stream for execution
         if stream.buffered_send_data > 0 {
-            debug_assert!(stream.send_flow.available() > 0);
-
             // TODO: This assertion isn't *exactly* correct. There can still be
             // buffered send data while the stream's pending send queue is
             // empty. This can happen when a large data frame is in the process
diff --git a/tests/flow_control.rs b/tests/flow_control.rs
index 360cd8a..e8ee22e 100644
--- a/tests/flow_control.rs
+++ b/tests/flow_control.rs
@@ -1150,3 +1150,49 @@ fn server_target_window_size() {
 
     srv.join(client).wait().unwrap();
 }
+
+
+#[test]
+fn recv_settings_increase_window_size_after_using_some() {
+    // See https://github.com/carllerche/h2/issues/208
+    let _ = ::env_logger::init();
+    let (io, srv) = mock::new();
+
+    let new_win_size = 16_384 * 4; // 1 bigger than default
+    let srv = srv.assert_client_handshake()
+        .unwrap()
+        .recv_settings()
+        .recv_frame(
+            frames::headers(1)
+                .request("POST", "https://http2.akamai.com/")
+        )
+        .recv_frame(frames::data(1, vec![0; 16_384]))
+        .recv_frame(frames::data(1, vec![0; 16_384]))
+        .recv_frame(frames::data(1, vec![0; 16_384]))
+        .recv_frame(frames::data(1, vec![0; 16_383]))
+        .send_frame(
+            frames::settings()
+                .initial_window_size(new_win_size as u32)
+        )
+        .recv_frame(frames::settings_ack())
+        .send_frame(frames::window_update(0, 1))
+        .recv_frame(frames::data(1, vec![0; 1]).eos())
+        .send_frame(frames::headers(1).response(200).eos())
+        .close();
+
+    let client = Client::handshake(io).unwrap()
+        .and_then(|(mut client, conn)| {
+            let request = Request::builder()
+                .method("POST")
+                .uri("https://http2.akamai.com/")
+                .body(()).unwrap();
+            let (resp, mut req_body) = client.send_request(request, false).unwrap();
+            req_body.send_data(vec![0; new_win_size].into(), true).unwrap();
+            conn.drive(resp.expect("response"))
+        })
+        .and_then(|(conn, _res)| {
+            conn.expect("client")
+        });
+
+    srv.join(client).wait().unwrap();
+}